Re: [PATCH 1/2] dccp: ccid: move timers to struct dccp_sock
Jakub Kicinski <[email protected]>
| Newsgroups | org.kernel.vger.dccp,org.kernel.vger.linux-kernel,org.kernel.vger.netdev |
|---|---|
| Message-ID | <20201014204322.7a51c375@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> |
On Tue, 13 Oct 2020 19:18:48 +0200 Kleber Sacilotto de Souza wrote: > From: Thadeu Lima de Souza Cascardo <[email protected]> > > When dccps_hc_tx_ccid is freed, ccid timers may still trigger. The reason > del_timer_sync can't be used is because this relies on keeping a reference > to struct sock. But as we keep a pointer to dccps_hc_tx_ccid and free that > during disconnect, the timer should really belong to struct dccp_sock. > > This addresses CVE-2020-16119. > > Fixes: 839a6094140a (net: dccp: Convert timers to use timer_setup()) Presumably you chose this commit because the fix won't apply beyond it? But it really fixes 2677d2067731 (dccp: don't free.. right? > Signed-off-by: Thadeu Lima de Souza Cascardo <[email protected]> > Signed-off-by: Kleber Sacilotto de Souza <[email protected]>