Re: [PATCH v3 1/2] livetree: Simplify append_to_property()

Uwe Kleine-König <[email protected]> Tue, 19 Aug 2025 13:24:52 +0200
Newsgroups	org.kernel.vger.devicetree-compiler
Message-ID	<pdqikbvsxfxvjztooptpwt3esz42t5msncbh2ixpxpqitbmen7@hjfst72gvoac>
Hello David,

On Tue, Aug 19, 2025 at 04:17:43PM +1000, David Gibson wrote:
> On Tue, Aug 19, 2025 at 07:35:39AM +0200, Uwe Kleine-König wrote:
> > On Tue, Aug 19, 2025 at 09:25:35AM +1000, David Gibson wrote:
> > > On Mon, Aug 18, 2025 at 12:38:57PM +0200, Uwe Kleine-König wrote:
> > > > Argh, I failed to add my s-o-b line here. Maybe b4 picks it up when I
> > > > write:
> > > > 
> > > > Signed-off-by: Uwe Kleine-König <[email protected]>
> > > 
> > > Heh, thanks for adding this after.  I'll take it from here and paste
> > > it in.
> > 
> > Does that mean you're not using b4, or that b4 doesn't pick it up?
> 
> I'm not using b4 - never had enough impetus to figure it out.

In this case it would be just:

	b4 am -s -l -t -3 aKQXB5PuW-vt9zKJ@zatzit

and then execute the git-am at the end of its output.
("aKQXB5PuW-vt9zKJ@zatzit" is just a message id from one mail in the
thread you want to apply.)

I think it doesn't need any preparatory configuration to make that work.

The output for me (after changing my email address in .git/config to
test if my late S-o-b is picked up) is:

	$ b4 am -s -l -t -3 aKQXB5PuW-vt9zKJ@zatzit
	Analyzing 7 messages in the thread
	Analyzing 7 code-review messages
	Checking attestation on all messages, may take a moment...
	---
	  ✓ [PATCH v3 1/2] livetree: Simplify append_to_property()
	    + Signed-off-by: Uwe Kleine-König <[email protected]> (✓ DKIM/baylibre-com.20230601.gappssmtp.com)
	    + Link: https://lore.kernel.org/r/eef88e559f5b9818c4c2311fa8a75ab6fd4508d5.1755512759.git.u.kleine-koenig@baylibre.com
	    + Signed-off-by: Uwe Kleine-König <[email protected]>
	  ✓ [PATCH v3 2/2] livetree: Add only new data to fixup nodes instead of complete regeneration
	    + Link: https://lore.kernel.org/r/b061ee57157fafbb9d5b9b0b86af760d13a04eda.1755512759.git.u.kleine-koenig@baylibre.com
	    + Signed-off-by: Uwe Kleine-König <[email protected]>
	  ---
	  ✓ Signed: openpgp/[email protected]
	  ✓ Signed: DKIM/baylibre-com.20230601.gappssmtp.com (From: [email protected])
	---
	Total patches: 2
	Preared a fake commit range for 3-way merge (62461e41cde3..3dab71c00c24)
	---
	Cover: ./v3_20250818_u_kleine_koenig_livetree_add_only_new_data_to_fixup_nodes_instead_of_complete_regenerati.cover
	 Link: https://lore.kernel.org/r/[email protected]
	 Base: using specified base-commit 84d9dd2fcbc865a35d7f04d9b465b05ef286d281
	       git checkout -b v3_20250818_u_kleine_koenig_baylibre_com 84d9dd2fcbc865a35d7f04d9b465b05ef286d281
	       git am -3 ./v3_20250818_u_kleine_koenig_livetree_add_only_new_data_to_fixup_nodes_instead_of_complete_regenerati.mbx

So the added value is:

 - adds your Signed-off-by line (-s)
 - adds a Link: trailer (-l)
 - collects tags from replies to patches (also my late S-o-b)
 - collects tags from replies on the cover message and applies it to all
   patches (-t, though doesn't apply here)
 - apply some magic to make it more likely that git can apply the patch
   if you have a different base than the submitter (-3)
 - checks openpgp, DKIM etc.

Best regards
Uwe
signature.asc (application/pgp-signature, 488 B)