Re: [PATCH v3 2/2] livetree: Add only new data to fixup nodes instead of complete regeneration

On Mon, Aug 18, 2025 at 12:35:46PM +0200, Uwe Kleine-König wrote:
> Removing the complete __fixups__ and __local_fixups__ tree might delete
> data that should better be retained. See the added test for a situation
> that was broken before.
> 
> Note that without removing /__fixups__ and /__local_fixups__ in
> generate_fixups_tree() and generate_local_fixups_tree() respectively
> calling build_and_name_child_node() isn't safe as the nodes might
> already exist and then a duplicate would be added. So build_root_node()
> has to be used which copes correctly here.
> 
> Fixes: 915daadbb62d ("Start with empty __local_fixups__ and __fixups__ nodes")
> Closes: https://github.com/dgibson/dtc/issues/170
> Signed-off-by: Uwe Kleine-König <[email protected]>

Merged. thanks.

Note that I generally prefer negative values for error codes (-1
instead of 1).  I altered that on merge.

-- 
David Gibson (he or they)	| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you, not the other way
				| around.
http://www.ozlabs.org/~dgibson

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmils8IACgkQzQJF27ox
2GecTg/8DLHCtGUp3eB+FLF4V2QDlEIWZPTVwvo3NE3v6q38qoW/zSWhY6S3NO2G
4dv0Fx91adFpp9sYqaP7RWN72WDx8vCjcrQhtsXku1vPH1ftVRsgqsySyrAt+I8E
/VSnH5Kq3e4L0btbhNT6bABNy5VXFfY+jEhrv0YR9xtizjmJGXMNKKJo55QoxSDd
EdbKVxWgGoHtTWykFKNgK1LcYZDWrAlZA3Z9wgISStnbkRSaBPunSY4vKGD/rx96
gRvUeQ8yd+OmOBwjYbb9PzyyBjCEkVISsJd0AIC/GuYbVL7OCtwXfzx5jKtWQRWV
acN1PWobPctgGTde38URohJPI/zQTDIGoP7xxD0Ok3FqvNyW+CIjQB5RLm+hJ85b
3pONcp+8Vmc9pmF6hyevLk73ateQNl02SIwDIlT7zz6qPDReD8DwoPiSJ3h+gy2v
efJrkTQNfeY9Ytkrd8CQ0/pJ0txtbVZefaw4bt5ERKkIU1zd/ihNIcv+2wHDj1tS
J838pPca28+x0DdqvFQfACaUApVpF0fyTiSIVqdjTCZ027HP55qslVPT33BXFwfB
68KaZbhgU2inidjuToX6JPES2U9dCL8X2NC8W2+CFWyT84UwIZ2KVsUIEV8WrJhc
ewO3ergUHGLzTc/wDUci2/cOdkmZ5PMOSf/u+DgOoN7dSMirxEc=
=Kpdi
-----END PGP SIGNATURE-----