Re: [PATCH dt-schema] schemas: i2c: add optional GPIO binding for SMBALERT# line
Wolfram Sang <[email protected]>
| Newsgroups | org.kernel.vger.devicetree-spec,org.kernel.vger.linux-i2c,org.kernel.vger.linux-renesas-soc |
|---|---|
| Message-ID | <ZuKLpilWKCS5k7Kx@shikoro> |
> I had this originally in my RFC[1]. I got convinced by Geert's arguments
> because the DT snippet in the board DTS looked kinda ugly. The board
> needs to override the DTSI of the SoC to replace "interrupts" with
> "interrupts-extended":
>
> ===
>
> &i2c3 {
> pinctrl-0 = <&i2c3_pins>;
> pinctrl-names = "i2c-pwr";
> +
> + /delete-property/ interrupts;
> + interrupts-extended = <&gic GIC_SPI 290 IRQ_TYPE_LEVEL_HIGH>, <&gpio1 26 IRQ_TYPE_EDGE_FALLING>;
> + interrupt-names = "main", "smbus_alert";
> +
> + smbus;
> };
>
> ===
I guess my questions here are: is this proper? Is there a better way to
describe it? Is using interrupts still the way to go?
Thanks for the guidance and happy hacking!
signature.asc
(application/pgp-signature, 833 B)
-----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmbii6YACgkQFA3kzBSg KbbZrQ/+ISHD3cqlO+60QfhsSyi6JOsnODJcQ0GXCMH42/CvwgF9zV8/DiDIZO+H qvaGq6Czm+OTUp7HkY3FYsS5udF6XcQuZwfeAs70TkP8QAv9zW5HDFgzzfgazeWb L20ycT1KF/ANUE9yJGGXV72dKaooMw0i03FZ/IjuJNX0J3yHCtgcbbXtme4XKq4D 6wI7peiNLg+uHhK57utE0A4yMsih9rm0ouPzwPjDn8yQhekn7B8jye/ICqAd9uKe lpMNzJAksPoKu1CGOvML95b5TebachZSKLxzLC28THQ3SdbZ+B0AUYXcB4T+QDBH /K1PxCte6BVl4/ed6tLaGJlDZ5lDYwYZDLqpSVAu1EnGKpYSvwS7Tv08hoT3yjig 7aXe0Txk0eE1w9Q15gfpedlh0uhp5Er5O/wi3WAdQALZ/zXQxQvqa2vro7aCJwz8 GiMjeJM1dbCLXRopUcWcpP2fM1Bh5YlM+MIHz8FpbY7IsJ8Al94USP5oIVl1pZ/X WRPYRhCBg4ee8BZ60TQSoACjx8MilKtoSPviMqb/sKwAKsms83YGjJiNs+9uVpE5 iKdR/+95ovcqNnj1Y79fknAaSi6FLItcnIxtdDiNNJMdF/PsnheViZhGjGLiWSzq adL59XnrU9Bvu86iHBKRnXWnLjYdnZf0OVNAK9FhPUP/gelclN0= =JKkW -----END PGP SIGNATURE-----