Re: [PATCH dt-schema] schemas: i2c: add optional GPIO binding for SMBALERT# line

Wolfram Sang <[email protected]> Tue, 10 Sep 2024 09:38:02 +0200

Newsgroups	org.kernel.vger.devicetree-spec,org.kernel.vger.linux-i2c,org.kernel.vger.linux-renesas-soc
Message-ID	<Zt_3WtlRP_5wt4PN@shikoro>

Hi Rob,

thanks for your review!

> I believe "gpios" is what was originally supported, but now it is
> preferred if GPIOs are used as interrupts then we use interrupts in
> DT.

I had this originally in my RFC[1]. I got convinced by Geert's arguments
because the DT snippet in the board DTS looked kinda ugly. The board
needs to override the DTSI of the SoC to replace "interrupts" with
"interrupts-extended":

===

 &i2c3	{
 	pinctrl-0 = <&i2c3_pins>;
 	pinctrl-names = "i2c-pwr";
+
+	/delete-property/ interrupts;
+	interrupts-extended = <&gic GIC_SPI 290 IRQ_TYPE_LEVEL_HIGH>, <&gpio1 26 IRQ_TYPE_EDGE_FALLING>;
+	interrupt-names = "main", "smbus_alert";
+
+	smbus;
 };

===

It works, though.

All the best,

   Wolfram

[1] http://patchwork.ozlabs.org/project/linux-i2c/patch/[email protected]/

signature.asc (application/pgp-signature, 833 B)