Re: [PATCH] dmaengine: bestcomm: set bcom_eng to NULL on probe failure
Frank Li <[email protected]>
| Newsgroups | org.kernel.vger.dmaengine,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <aoMS3r6mQjDMKbMx@SMW015318> |
On Sun, Aug 16, 2026 at 06:54:42PM -0700, Rosen Penev wrote:
> Functions like bcom_task_alloc() use if (!bcom_eng) as a safety readiness
> check. If the probe fails and hits this error path, subsequent or concurrent
> API calls will bypass the check and dereference the freed memory.
>
> Fixes: 9560aea4e9d1 ("[POWERPC] mpc5200: Fix null dereference if bestcomm fails to initialize")
> Signed-off-by: Rosen Penev <[email protected]>
> ---
Not sure that still have power pc user.
Reviewed-by: Frank Li <[email protected]>
> drivers/dma/bestcomm/bestcomm.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/dma/bestcomm/bestcomm.c b/drivers/dma/bestcomm/bestcomm.c
> index 432b43520ddc..ec58d2c6573f 100644
> --- a/drivers/dma/bestcomm/bestcomm.c
> +++ b/drivers/dma/bestcomm/bestcomm.c
> @@ -445,6 +445,7 @@ static int mpc52xx_bcom_probe(struct platform_device *op)
> release_mem_region(res_bcom.start, sizeof(struct mpc52xx_sdma));
> error_sramclean:
> kfree(bcom_eng);
> + bcom_eng = NULL;
> bcom_sram_cleanup();
> error_ofput:
> of_node_put(op->dev.of_node);
> --
> 2.55.0
>