Re: [PATCH v2] generic/730: skip test if DAX mount option is enabled

On Mon, Mar 23, 2026 at 06:10:05PM +0530, Disha Goel wrote:
> The generic/730 test utilizes the scsi_debug driver to create a
> synthetic SCSI block device. Since scsi_debug does not support
> DAX capabilities, attempting to mount it with "-o dax" results
> in failures (specifically on ext4).
> 
> Since this test is not DAX-related, exclude it when DAX is
> specified in MOUNT_OPTIONS to avoid compatibility issues with
> scsi_debug.
> 
> Signed-off-by: Disha Goel <[email protected]>
> ---
> Changelog v1 -> v2:
> Use _exclude_scratch_mount_option instead of an ext4-specific check.

This version is good to me, although g/730 doesn't have _require_scratch :)

Reviewed-by: Zorro Lang <[email protected]>

> 
> Link to v1:
> https://lore.kernel.org/all/[email protected]/
> ---
>  tests/generic/730 | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/generic/730 b/tests/generic/730
> index 6b5d3196..47073f42 100755
> --- a/tests/generic/730
> +++ b/tests/generic/730
> @@ -19,7 +19,7 @@ _cleanup()
>  
>  . ./common/filter
>  . ./common/scsi_debug
> -
> +_exclude_scratch_mount_option "dax"
>  
>  # We don't actually use the test device, but we need a block based fs
>  _require_test
> -- 
> 2.45.1
> 
>