Re: [PATCH] generic/301: skip extent count check on btrfs

On Tue, Mar 24, 2026 at 10:48:48PM -0700, Christoph Hellwig wrote:
> On Tue, Mar 24, 2026 at 01:40:00PM -0700, Leo Martins wrote:
> > +# btrfs CoW extent allocation depends on transaction commit frequency and
> > +# metadata reservation behavior, so the 2/3 fragmentation threshold (designed
> > +# for XFS cowextsize) is not applicable.
> 
> It really is a quality of implementation issue and not specifically
> designed for XFS.  But I gues it is hard to force quality of
> implementation on specific file systems.
> 
> > +if [ "$FSTYP" != "btrfs" ]; then
> > +	test $new_extents -lt $((internal_blks * 2 / 3)) || echo "file2 badly fragmented"
> 
> Please break the echo into a separate line to keep this readable,
> either by just breaking using \ or by turning this into a proper if
> statement.

Sure, I'll help to change it to:

	test $new_extents -lt $((internal_blks * 2 / 3)) || \
		echo "file2 badly fragmented"

when I merge it.

Thanks,
Zorro

> 
>