Re: [PATCH v6 02/11] fstests: add _clone_mount_option() helper
Anand Suveer Jain <[email protected]>
| Newsgroups | org.kernel.vger.fstests,net.sourceforge.lists.linux-f2fs-devel,org.kernel.vger.linux-btrfs,org.kernel.vger.linux-ext4,org.kernel.vger.linux-xfs |
|---|---|
| Message-ID | <[email protected]> |
On 29/5/26 12:28, Darrick J. Wong wrote: > On Thu, May 28, 2026 at 12:05:33PM +0800, Anand Jain wrote: >> Adds _clone_mount_option() helper function to handle filesystem-specific >> requirements for mounting cloned devices. Abstract the need for -o nouuid >> on XFS. >> >> Signed-off-by: Anand Jain <[email protected]> >> --- >> common/rc | 17 +++++++++++++++++ >> 1 file changed, 17 insertions(+) >> >> diff --git a/common/rc b/common/rc >> index d7e3e0bdfb1e..937f478963b4 100644 >> --- a/common/rc >> +++ b/common/rc >> @@ -414,6 +414,23 @@ _scratch_mount_options() >> $SCRATCH_DEV $SCRATCH_MNT >> } >> >> +# Return filesystem-specific mount options required for mounting clone/snapshot >> +# devices. >> +_clone_mount_option() >> +{ >> + local mount_opts="" >> + >> + case "$FSTYP" in >> + xfs) >> + # Allow mounting a duplicate filesystem on the same host >> + mount_opts="-o nouuid" >> + ;; >> + *) >> + esac >> + >> + echo $mount_opts > > I probably would've just echo'd straight from inside the case statement, Nice. Let's see if there is v7, I will change this to as below. > but this otherwise looks ok, > Reviewed-by: "Darrick J. Wong" <[email protected]> > > --D > diff --git a/common/rc b/common/rc index 79be51e4da31..18d4f73cead9 100644 --- a/common/rc +++ b/common/rc @@ -418,17 +418,13 @@ _scratch_mount_options() # devices. _clone_mount_option() { - local mount_opts="" - case "$FSTYP" in xfs) # Allow mounting a duplicate filesystem on the same host - mount_opts="-o nouuid" + echo "-o nouuid" ;; *) esac - - echo $mount_opts } _supports_filetype() >> +} >> + >> _supports_filetype() >> { >> local dir=$1 >> -- >> 2.43.0 >> >>