Re: [PATCH 3/5] generic/746: skip on zoned btrfs

Christoph Hellwig <[email protected]> Mon, 20 Jul 2026 10:37:38 -0700
Newsgroups org.kernel.vger.fstests,org.kernel.vger.linux-btrfs
Message-ID <[email protected]>
On Mon, Jul 20, 2026 at 01:18:47PM +0200, Johannes Thumshirn wrote:
> The test relies on loop device discards punching holes in the backing
> image file (holes are then detected via fiemap on the backing file).
> Zoned btrfs does not support fallocate/punch hole, so fstrim on the
> loop device cannot free space in the backing file and the test cannot
> work.
> 
> Skip the test on zoned devices, but only for btrfs so that other
> filesystems (e.g. zoned XFS/f2fs) can still run it.

This should use feature detection and not hard code file systems.

I'm also a bit surprised that zoned btrfs doesn't support hole
punches.  Unlike classic unwritten extents there is nothing in a
zone model preventing them from working.  Did you try just enabling
hole punches in btrfs?