Re: [PATCH 1/5] common/btrfs: fix awk field separator in _check_temp_fsid

Johannes Thumshirn <[email protected]> Tue, 21 Jul 2026 08:43:40 +0200
Newsgroups org.kernel.vger.fstests,org.kernel.vger.linux-btrfs
Message-ID <[email protected]>
On 20.07.26 18:44, Filipe Manana wrote:
> On Mon, Jul 20, 2026 at 12:34 PM Johannes Thumshirn
> <[email protected]> wrote:
>>
>> _check_temp_fsid() extracted the on-disk fsid with "awk -d\" \"",
>> but -d is gawk's --dump-variables option, not a field separator.
>> As a result awk tried to open a file named " " for writing and dumped
>> its variable list, polluting the test output with messages like:
>>
>>    awk: warning: could not open ' ' for writing: Read-only file system
>>    awk: warning: sending variable list to standard error
>>    ARGC: 1
>>    ARGIND: 0
>>    ...
>>
>> which made btrfs/311 (the only test currently exercising this helper)
>> fail. Use -F" " to set the field separator as intended.
> 
> This is all correct and makes sense.
> 
> I wonder why the test doesn't fail on my Debian box.
> My awk is a symlink to gawk and the man page, as well as running 'awk
> --help', confirms -d is to dump variables to a file and -F is the
> field separator as you say here.
> 
> So I'm puzzled. Any idea?
I have no idea. Fails reliably on all my Fedora boxes.