Re: git config: unintuitive behaviour with --global and --no-includes
Junio C Hamano <[email protected]>
| Newsgroups | org.kernel.vger.git |
|---|---|
| Message-ID | <[email protected]> |
Jeff King <[email protected]> writes: > IMHO lbmk is wrong to be using "--global" in the first place. Looking at > the source, it is trying to check whether the user has set up their > identity. But it is not lbmk's business whether you did it in the > --global config file, or elsewhere! Exactly. > Though note there is one other hitch, which is that the user can set > author.* and committer.* as specific variables, since 39ab4d0951 > (config: allow giving separate author and committer idents, 2019-02-04). > I suspect not many people do that, but that would also be something that > a config-specific check would have to handle (but "git var" would do > automatically). > > So I think you might consider sending a bug report to lbmk. Feel free to > point at this thread, and I'm happy to discuss further with them. Thanks for your thoughtful and thorough explanation. The environment variables 'GIT_{AUTHOR,COMMITTER}_{NAME,EMAIL}' also play a part in determining the author andcommitter identities, so 'git var AUTHOR_IDENT' would be the correct choice here.