Re: [PATCH] sequencer: remove unnecessary variable setting
Patrick Steinhardt <[email protected]>
| Newsgroups | org.kernel.vger.git |
|---|---|
| Message-ID | <[email protected]> |
On Wed, Aug 12, 2026 at 06:42:38AM +0000, Elijah Newren via GitGitGadget wrote:
> diff --git a/sequencer.c b/sequencer.c
> index 83c3849205..a0abcc69ce 100644
> --- a/sequencer.c
> +++ b/sequencer.c
> @@ -6277,7 +6277,6 @@ int sequencer_make_script(struct repository *r, struct strbuf *out,
> revs.sort_order = REV_SORT_IN_GRAPH_ORDER;
> revs.topo_order = 1;
>
> - revs.pretty_given = 1;
> repo_config_get_string(the_repository, "rebase.instructionFormat", &format);
> if (!format || !*format) {
> free(format);
Makes sense. The only reference to this field is indeed in
"builtin/log.c", and as we don't use the sequencer there shouldn't be
any kind of interaction between those two subsystems here.
Thanks!
Patrick