Re: [hail patch 1/1] Fix calling convention of huri_field_escape

Jeff Garzik <[email protected]> Mon, 27 Sep 2010 22:47:05 -0400

Newsgroups	org.kernel.vger.hail-devel
Message-ID	<[email protected]>

On 09/27/2010 08:49 PM, Pete Zaitcev wrote:
> Premature optimization is the root of all evil.
>
> Use a sensible convention of not screwing with the argument, at the expense
> of extra strdup.
>
> Fortunately, all users are confined to Hail itself, even if huri_field_escape
> is exported.
>
> Signed-off-by: Pete Zaitcev<[email protected]>
>
> ---
>   include/hstor.h |    2 +-
>   lib/hstor.c     |   44 +++++++++++++++++++++++++++++---------------
>   lib/huri.c      |   10 +++++-----
>   3 files changed, 35 insertions(+), 21 deletions(-)

applied