Re: [tabled patch 1/1] Add a test for hstor_keys
Jeff Garzik <[email protected]> Mon, 27 Sep 2010 22:49:46 -0400
| Newsgroups | org.kernel.vger.hail-devel |
|---|---|
| Message-ID | <[email protected]> |
On 09/27/2010 08:52 PM, Pete Zaitcev wrote: > Our current tests do not invoke hstor_keys at all, and so they did not catch > a crash with double free in append_qparam. > > Add a very basic test which at least calls hstor_keys to verify that it > does not crash right away. This test does not excercise complex modes > such as S3 paging, but better this than nothing. > > Signed-off-by: Pete Zaitcev<[email protected]> > > --- > test/Makefile.am | 4 + > test/list-keys.c | 102 +++++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 105 insertions(+), 1 deletion(-) applied.. FYI you forgot to update test/.gitignore. Fixed.