[PATCH net] net: rnpgbe: Pass an expression directly in rnpgbe_rm_adapter()
Markus Elfring <[email protected]> Sun, 12 Jul 2026 20:35:21 +0200
| Newsgroups | org.kernel.vger.kernel-janitors,org.kernel.vger.linux-kernel,org.kernel.vger.netdev |
|---|---|
| Message-ID | <[email protected]> |
From: Markus Elfring <[email protected]> Date: Sun, 12 Jul 2026 20:25:10 +0200 The address of a data structure member was determined before a corresponding null pointer check in the implementation of the function “rnpgbe_rm_adapter”. Thus avoid the risk for undefined behaviour by omitting the variable “hw”. Pass the required address directly to a function call. This issue was detected by using the Coccinelle software. Fixes: 2ee95ec17e97c58b65e978a08b75fa8cb6424e4e ("net: rnpgbe: Add register_netdev") Cc: [email protected] Signed-off-by: Markus Elfring <[email protected]> --- drivers/net/ethernet/mucse/rnpgbe/rnpgbe_main.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ethernet/mucse/rnpgbe/rnpgbe_main.c b/drivers/net/ethernet/mucse/rnpgbe/rnpgbe_main.c index 70a2b0082ba8..93cf757c951c 100644 --- a/drivers/net/ethernet/mucse/rnpgbe/rnpgbe_main.c +++ b/drivers/net/ethernet/mucse/rnpgbe/rnpgbe_main.c @@ -245,7 +245,6 @@ static int rnpgbe_probe(struct pci_dev *pdev, const struct pci_device_id *id) static void rnpgbe_rm_adapter(struct pci_dev *pdev) { struct mucse *mucse = pci_get_drvdata(pdev); - struct mucse_hw *hw = &mucse->hw; struct net_device *netdev; int err; @@ -253,7 +252,7 @@ static void rnpgbe_rm_adapter(struct pci_dev *pdev) return; netdev = mucse->netdev; unregister_netdev(netdev); - err = rnpgbe_send_notify(hw, false, mucse_fw_powerup); + err = rnpgbe_send_notify(&mucse->hw, false, mucse_fw_powerup); if (err) dev_warn(&pdev->dev, "Send powerdown to hw failed %d\n", err); free_netdev(netdev); -- 2.55.0