Re: [PATCH net] net: rnpgbe: Pass an expression directly in rnpgbe_rm_adapter()

Vadim Fedorenko <[email protected]> Sun, 12 Jul 2026 23:19:51 +0100
Newsgroups org.kernel.vger.kernel-janitors,org.kernel.vger.linux-kernel,org.kernel.vger.netdev
Message-ID <[email protected]>
On 12/07/2026 19:35, Markus Elfring wrote:
> From: Markus Elfring <[email protected]>
> Date: Sun, 12 Jul 2026 20:25:10 +0200
> 
> The address of a data structure member was determined before
> a corresponding null pointer check in the implementation of
> the function “rnpgbe_rm_adapter”.

The null check in rnpgbe_rm_adapter() looks more like defensive
programming, which got into the code unnoticed. pdev will not exist if
netdev is not allocated, where mucse is netdev private data.