Re: [PATCH 0/4] decouple vcpu index from apic id

On Tue, Jun 09, 2009 at 10:30:01AM +0800, Zhang, Xiantao wrote:
> Avi Kivity wrote:
> > Gleb Natapov wrote:
> >> Currently vcpu_id is used as an index into vcpus array and as apic id
> >> on x86.  This is incorrect since apic ids not have to be continuous
> >> (they can also encode cpu hierarchy information) and may have values
> >> bigger then vcpu array in case of x2apic. This series removes use of
> >> vcpu_id as vcpus array index. Each architecture may use it how it
> >> sees fit. x86 uses it as apic id. 
> >> 
> >> 
> > 
> > Apart from my minor comments, this looks good, but I'd like to get
> > acks from arch maintainers to avoid surprises.
> > 
> > Xiantao, does setting the bsp id make sense for ia64?
> 
> Make sense for ia64, if bsp id is set to 0.
> But still have one comment about the patchset, in Patch[3/4], online_vcpus in kvm structure is introduced, but it should have the conflicts with arch.online_vcpus for ia64. So I think it should be fixed before check-in. 
Patch 4/4 removes use of arch.online_vcpus. online_vcpus are used instead.
I'll move arch.online_vcpus removal to patch 3/4 instead.

--
			Gleb.