Re: [PATCH 3/3] media: i2c: Use ACPI_PTR() for ACPI ID tables
Sakari Ailus <[email protected]>
| Newsgroups | org.kernel.vger.linux-acpi,org.kernel.vger.linux-media |
|---|---|
| Organization | Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo |
| Message-ID | <[email protected]> |
Hi Andy, On Fri, Aug 28, 2026 at 03:30:10PM +0200, Andy Shevchenko wrote: > On Fri, Aug 28, 2026 at 11:43:28AM +0300, Sakari Ailus wrote: > > Add ACPI_PTR() to the ACPI ID tables where missing. The patch has been > > produced with the following command: > > > > git grep -lP 'acpi_match_table.*=\s*(?!ACPI_PTR)' \ > > drivers/media/|while read i; do > > perl -i -pe 's/\.acpi_match_table\s*=\s*\K(\w+),/ACPI_PTR($1),/' $i; > > done > > NAK. > > It doesn't explain why we need that. This also inconsistent with OF type of > IDs. ACPI IDs are used on ACPI only while compatible strings are used on both ACPI and OF. Thus the ACPI ID table is redundant if CONFIG_ACPI is disabled. -- Sakari Ailus