Re: [PATCH 3/3] media: i2c: Use ACPI_PTR() for ACPI ID tables

On Fri, Aug 28, 2026 at 06:10:55PM +0300, Sakari Ailus wrote:
> On Fri, Aug 28, 2026 at 03:30:10PM +0200, Andy Shevchenko wrote:
> > On Fri, Aug 28, 2026 at 11:43:28AM +0300, Sakari Ailus wrote:
> > > Add ACPI_PTR() to the ACPI ID tables where missing. The patch has been
> > > produced with the following command:
> > > 
> > > git grep -lP 'acpi_match_table.*=\s*(?!ACPI_PTR)' \
> > > 	drivers/media/|while read i; do
> > > 	perl -i -pe 's/\.acpi_match_table\s*=\s*\K(\w+),/ACPI_PTR($1),/' $i;
> > > done
> > 
> > NAK.
> > 
> > It doesn't explain why we need that. This also inconsistent with OF type of
> > IDs.
> 
> ACPI IDs are used on ACPI only while compatible strings are used on both
> ACPI and OF. Thus the ACPI ID table is redundant if CONFIG_ACPI is
> disabled.

They may be informative for the cases when on the working say OF system I can
get the IDs for ACPI based platforms at run-time.

Also you just save a couple of dozens of bytes. This is peanuts and unneeded
churn. Again, here is my formal

NAKed-by: Andy Shevchenko <[email protected]>

In case you want to override that, please keep it in the commit message (among
other tags). And yes, we have such a tag in the Git history of Linux kernel.

-- 
With Best Regards,
Andy Shevchenko