Re: [PATCH 3/4] arm64: dts: qcom: sm8250-xiaomi-elish: label the WiFi node

Krzysztof Kozlowski <[email protected]> Tue, 4 Aug 2026 10:10:55 +0200

Newsgroups	org.kernel.vger.linux-arm-msm,org.freedesktop.lists.dri-devel,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel
Message-ID	<20260804-glossy-mastodon-from-sirius-db9aac@quoll>

On Thu, Jul 30, 2026 at 11:52:02PM +0200, Dawid Wr=C3=B3bel wrote:
> The Mi Pad 5 Pro 5G shares this device tree but needs its own board data
> variant, so give the node a label to allow overriding the property.
>=20
> Signed-off-by: Dawid Wr=C3=B3bel <[email protected]>
> ---
>  arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi b/a=
rch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi
> index 19aff83ecf7b..12a2ba48340f 100644
> --- a/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi
> @@ -817,7 +817,7 @@ &pcie0_phy {
>  };
> =20
>  &pcieport0 {
> -	wifi@0 {
> +	wifi_0: wifi@0 {

This is pointless on its own. Label does not end up in DTB, so your
patch has zero effect.

You miss the user of the label here.

Best regards,
Krzysztof