Re: [PATCH] bcache: fix NULL pointer in cache_set_flush()

> 2025年4月9日 09:42，邹明哲 <[email protected]> 写道：
> 
> &gt;Nice catch!  Thanks for the fix up!
> 
> &gt;There are two suggestions from me,
> 
> Hi, Coly Li
> 
> &gt;1) the above code example is from 4.18 kernel I guess, could you please
> &gt;   update the commit log against latest upstream kernel code?
> 
> Firstly, this is a fairly (about 4-5 years ago) old patch. Now, we have
> rebased to the 6.6 kernel. We have no more crashes, so we are unable to
> obtain the latest message logs.

OK, then forget this suggestion, I will refine the commit log.


> 
> &gt;2) Could you please add code commet here to explain why ca is checked
> &gt;   here? Let other people to know that in registration failure code
> &gt;   path, ca might be NULL. Such information could be quite helpful for
> &gt;   others to understand the code.
> 
> This is a good idea. I am currently dealing with other issues and will
> send the v2 version later.

Thanks.

Coly Li