Re: [PATCH] bcache: fix NULL pointer in cache_set_flush()

>Nice catch!  Thanks for the fix up!

>There are two suggestions from me,

Hi, Coly Li

>1) the above code example is from 4.18 kernel I guess, could you please
>   update the commit log against latest upstream kernel code?

Firstly, this is a fairly (about 4-5 years ago) old patch. Now, we have
rebased to the 6.6 kernel. We have no more crashes, so we are unable to
obtain the latest message logs.

>2) Could you please add code commet here to explain why ca is checked
>   here? Let other people to know that in registration failure code
>   path, ca might be NULL. Such information could be quite helpful for
>   others to understand the code.

This is a good idea. I am currently dealing with other issues and will
send the v2 version later.

mingzhe

>Coly Li