Re: [PATCH 16/17] zonefs: use bdev_rw_virt in zonefs_read_super
Johannes Thumshirn <[email protected]>
| Newsgroups | org.kernel.vger.linux-bcache,dev.linux.lists.dm-devel,dev.linux.lists.gfs2,org.kernel.vger.linux-block,org.kernel.vger.linux-btrfs,org.kernel.vger.linux-fsdevel,org.kernel.vger.linux-pm,org.kernel.vger.linux-xfs |
|---|---|
| Message-ID | <[email protected]> |
On 22.04.25 16:31, Christoph Hellwig wrote: > + super = kmalloc(PAGE_SIZE, GFP_KERNEL); > + if (!super) [...] > + ret = bdev_rw_virt(sb->s_bdev, 0, super, PAGE_SIZE, REQ_OP_READ); Can we change these two PAGE_SIZE into ZONEFS_SUPER_SIZE which is semantically more correct? Other than that, Reviewed-by: Johannes Thumshirn <[email protected]>