Re: [PATCH 04/17] block: remove the q argument from blk_rq_map_kern
hch <[email protected]>
| Newsgroups | org.kernel.vger.linux-bcache,dev.linux.lists.dm-devel,dev.linux.lists.gfs2,org.kernel.vger.linux-block,org.kernel.vger.linux-btrfs,org.kernel.vger.linux-fsdevel,org.kernel.vger.linux-pm,org.kernel.vger.linux-xfs |
|---|---|
| Message-ID | <[email protected]> |
On Tue, Apr 29, 2025 at 11:24:55AM +0000, Johannes Thumshirn wrote:
> > Good cleanup. I always wondered why we need to have it.
>
> Because we used to call 'bio_add_pc_page()' in e.g. bio_map_kern()'
> which took a request_queue. But that got changed in 6aeb4f8364806
> ("block: remove bio_add_pc_page") to a simple 'bio_add_page()'.
Even back then you could have easily derived it from the struct
request, through.