Re: [PATCH] btrfs: send: fix comment for SEND_MAX_DIR_UTIMES_CACHE_SIZE

On Mon, 15 Jun 2026 at 18:50, <[email protected]> wrote:
> From: Filipe Manana <[email protected]>
>
> The comment is wrong, because it's not about storing the ID of new
> directories that were already created, instead it's about storing utimes
> values for directories (both new and existing). The comment is wrong
> because it was copy pasted from SEND_MAX_DIR_CREATED_CACHE_SIZE, but
> forgot to update it afterwards.
>
> Signed-off-by: Filipe Manana <[email protected]>

LGTM

Reviewed-by: Daniel Vacek <[email protected]>

> ---
>  fs/btrfs/send.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/fs/btrfs/send.c b/fs/btrfs/send.c
> index 3ae480c7474b..a3c8f2d889bb 100644
> --- a/fs/btrfs/send.c
> +++ b/fs/btrfs/send.c
> @@ -130,10 +130,10 @@ static_assert(offsetof(struct backref_cache_entry, entry) == 0);
>  #define SEND_MAX_DIR_CREATED_CACHE_SIZE                        64
>
>  /*
> - * Max number of entries in the cache that stores directories that were already
> - * created. The cache uses raw struct btrfs_lru_cache_entry entries, so it uses
> - * at most 4096 bytes - sizeof(struct btrfs_lru_cache_entry) is 48 bytes, but
> - * the kmalloc-64 slab is used, so we get 4096 bytes (64 bytes * 64).
> + * Max number of entries in the cache that stores utimes values for directories.
> + * The cache uses raw struct btrfs_lru_cache_entry entries, so it uses at most
> + * 4096 bytes - sizeof(struct btrfs_lru_cache_entry) is 48 bytes, but the
> + * kmalloc-64 slab is used, so we get 4096 bytes (64 bytes * 64).
>   */
>  #define SEND_MAX_DIR_UTIMES_CACHE_SIZE                 64
>
> --
> 2.47.2
>
>