Re: [PATCH v3 0/2] btrfs: fix inlined file extent items in data reloc

On Tue, Jun 23, 2026 at 12:38 PM Qu Wenruo <[email protected]> wrote:
>
> [CHANGELOG]
> v3:
> - Use btrfs_is_data_reloc_root()
>
> - Reword the cause analyze to avoid confusion
>
> - Expand the [FIX] section to explain why disabling compression will
>   avoid inlined extents
>
> v2:
> - Add more explanation on why we can created inlined extents even if
>   relocation is preallocating space
>
> - Add the fixes: tag since the behavior is caused by a specific commit
>
> There is a syzbot report that an inlined file extent item in a data
> reloc inode triggered a sanity check in get_new_location().
>
> It turns out that we can create inlined file extents for data reloc
> inodes in the first place after commit 3eaf5f082c4c ("btrfs: extract
> inlined creation into a dedicated delalloc helper").
>
> So the first patch will avoid compression for data reloc inodes first,
> then the second patch to reject inlined file extent items in
> get_new_location(), making the checks more robust.
>
> Qu Wenruo (2):
>   btrfs: do not try compression for data reloc inodes
>   btrfs: reject inline file extents item in get_new_location()

Reviewed-by: Filipe Manana <[email protected]>

Thanks.

>
>  fs/btrfs/btrfs_inode.h | 2 ++
>  fs/btrfs/relocation.c  | 7 +++++++
>  2 files changed, 9 insertions(+)
>
> --
> 2.54.0
>
>