Re: [PATCH] tty: ldisc: fix deadlock between ldisc_sem and rtnl_mutex

>>>
>>> +      /*
>>
>> this blank line is redundant i believe
>>
> 
> Isn't it common practice to leave the first line of a multi-line comment 
> blank? Does it violate the coding style guidelines?
> 

You are right.

The non-blank first comment line is only common for networking but you 
posted a patch for the tty subsystem and not for networking.

Documentation/Codingstyle explains that:

     The preferred style for long (multi-line) comments is:

         /*
          * This is the preferred style for multi-line
          * comments in the Linux kernel source code.
          * Please use it consistently.
          *
          * Description:  A column of asterisks on the left side,
          * with beginning and ending almost-blank lines.
          */

     For files in net/ and drivers/net/ the preferred style for long 
(multi-line)
     comments is a little different.

         /* The preferred comment style for files in net/ and drivers/net
          * looks like this.
          *
          * It is nearly the same as the generally preferred comment style,
          * but there is no initial almost-blank line.
          */

Source: https://lwn.net/Articles/694755/

Best regards,
Oliver