RE: [PATCH] tty: ldisc: fix deadlock between ldisc_sem and rtnl_mutex

"Jagielski, Jedrzej" <[email protected]> Fri, 17 Jul 2026 07:02:04 +0000

Newsgroups	org.kernel.vger.linux-can,org.kernel.vger.linux-kernel,org.kernel.vger.linux-serial,org.kernel.vger.netdev
Message-ID	<PH0PR11MB59028DA3D84E76C5AD285A35F0C62@PH0PR11MB5902.namprd11.prod.outlook.com>

From: Zhou, Yun <[email protected]> 
Sent: Friday, July 17, 2026 5:42 AM

>>> +      tty_ldisc_unlock(tty);
>>>
>>> +      /*
>> 
>> this blank line is redundant i believe
>> 
>
>Isn't it common practice to leave the first line of a multi-line comment 
>blank? Does it violate the coding style guidelines?
>
>BR,
>Yun

First line of the comment unlike the last don't have to be necessarily
blank and indeed usually it is not for new code, it’s rather obsolete practice.
But that's only suggestion.