[PATCH v6 1/4] dt-bindings: can: rockchip: add rk3588 CAN-FD compatible
Cunhao Lu <[email protected]> Thu, 30 Jul 2026 22:34:02 +0800
| Newsgroups | org.kernel.vger.linux-can,org.infradead.lists.linux-arm-kernel,org.infradead.lists.linux-rockchip,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
RK3588 integrates a Rockchip CAN-FD controller variant that is not fully compatible with RK3568v2. The RX FIFO count register field is encoded in bits 7:5 on RK3588, while RK3568v2 uses bits 6:4. Add a dedicated rockchip,rk3588-canfd compatible to describe this variant. Do not use rockchip,rk3568v2-canfd as a fallback, because that would describe a register layout that does not match the hardware. Reviewed-by: Heiko Stuebner <[email protected]> Acked-by: Krzysztof Kozlowski <[email protected]> Signed-off-by: Cunhao Lu <[email protected]> --- v3 -> v4: - Collect Krzysztof's Acked-by tag. v2 -> v3: - Move the Changelog below --- - Collect Heiko's Reviewed-by tag v1 -> v2: - Use enum for the single-compatible entries, as suggested by Krzysztof. - Reword the commit message to explain the hardware difference instead of referring to Linux driver match data. --- .../devicetree/bindings/net/can/rockchip,rk3568v2-canfd.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/net/can/rockchip,rk3568v2-canfd.yaml b/Documentation/devicetree/bindings/net/can/rockchip,rk3568v2-canfd.yaml index a077c0330013..81e2b6dfeb02 100644 --- a/Documentation/devicetree/bindings/net/can/rockchip,rk3568v2-canfd.yaml +++ b/Documentation/devicetree/bindings/net/can/rockchip,rk3568v2-canfd.yaml @@ -16,7 +16,9 @@ allOf: properties: compatible: oneOf: - - const: rockchip,rk3568v2-canfd + - enum: + - rockchip,rk3568v2-canfd + - rockchip,rk3588-canfd - items: - const: rockchip,rk3568v3-canfd - const: rockchip,rk3568v2-canfd -- 2.34.1