Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] The compatible string 'ambarella,cv75-sec-scratchpad' was omitted from the 'select' block in syscon.yaml.
- [Low] The commit message subject for the MFD subsystem change does not capitalize the description.
--
--- Patch [2]: [PATCH v3 2/6] dt-bindings: mfd: syscon: add Ambarella CV75 secure scratchpad ---
commit ea79700d5daf0e265e9307d2ab596a80db0d5db8
Author: Long Zhao <[email protected]>
dt-bindings: mfd: syscon: add Ambarella CV75 secure scratchpad
Allow ambarella,cv75-sec-scratchpad with syscon for shared secure
scratchpad registers used by pinctrl pull configuration.
> dt-bindings: mfd: syscon: add Ambarella CV75 secure scratchpad
[Severity: Low]
This isn't a bug, but should the word "add" be capitalized here to follow
the MFD subsystem naming conventions?
> diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml b/Documentation/devicetree/bindings/mfd/syscon.yaml
> index e228670880631..05c7f59aba5de 100644
> --- a/Documentation/devicetree/bindings/mfd/syscon.yaml
> +++ b/Documentation/devicetree/bindings/mfd/syscon.yaml
> @@ -148,6 +148,7 @@ properties:
> - allwinner,sun50i-a64-system-controller
> - altr,l3regs
> - altr,sdr-ctl
> + - ambarella,cv75-sec-scratchpad
> - amd,pensando-elba-syscon
> - amlogic,meson-mx-assist
> - amlogic,meson-mx-bootrom
[Severity: Medium]
Will older dtschema tools skip validation for this new compatible string?
It appears this compatible string was omitted from the select block earlier
in the file, which is required for compatibility with dtschema <2024.02:
select:
properties:
compatible:
contains:
enum:
...
- altr,sdr-ctl
- amd,pensando-elba-syscon
Should ambarella,cv75-sec-scratchpad also be added to this enum block so
older tools correctly select and apply this schema?
--
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=2
lmpx.com only provides a reader for public news (NNTP) servers. It is not
affiliated with the servers or forums shown here and is not responsible for
the content of articles, which is written by their respective authors.