Re: [PATCH v3 3/6] dt-bindings: clock: add Ambarella CV75 RCT

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The binding for the Ambarella CV75 Reset and Clock Tree (RCT) is missing the `#reset-cells` property, failing to describe the hardware's reset provider capabilities. Device tree bindings must describe complete hardware capabilities rather than just the subset supported by the initial driver implementation.
--

--- Patch [3]: [PATCH v3 3/6] dt-bindings: clock: add Ambarella CV75 RCT ---
commit 34559a1295566c6903b0871d6d486afaede08d21
Author: Long Zhao <[email protected]>

dt-bindings: clock: add Ambarella CV75 RCT

This commit documents the CV75 RCT clock controller and the clock ID header
used by DT consumers. It introduces the new binding schema which defines
the register properties, clock requirements, and provides an example node.

> diff --git a/Documentation/devicetree/bindings/clock/ambarella,cv75-rct.yaml b/Documentation/devicetree/bindings/clock/ambarella,cv75-rct.yaml
> new file mode 100644
> index 0000000000000..eb5956fc32bc4
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/ambarella,cv75-rct.yaml
> @@ -0,0 +1,58 @@

[ ... ]

> +properties:

[ ... ]

> +  "#clock-cells":
> +    const: 1
> +
> +required:
> +  - compatible
> +  - reg
> +  - clocks
> +  - clock-names
> +  - "#clock-cells"

[Severity: Medium]
Since the commit message indicates this is a Reset and Clock Tree (RCT) block,
should #reset-cells be defined and included in this required properties list
to accurately reflect the hardware's role as a reset provider?

Device tree bindings typically need to describe complete hardware capabilities,
so existing device trees that omit the property will not silently pass schema
validation when reset support is eventually added.

> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    clock-controller@ed080000 {
> +        compatible = "ambarella,cv75-rct", "syscon";
> +        reg = <0xed080000 0x1000>;
> +        clocks = <&osc>;
> +        clock-names = "osc";
> +        #clock-cells = <1>;
> +    };

[Severity: Medium]
If #reset-cells is added to the binding, should this example node also be
updated to demonstrate its correct usage alongside #clock-cells?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=3