Re: [PATCH 12/16] arm64: dts: qcom: sm8550: Add GCC CX power domain
| Newsgroups | org.kernel.vger.linux-clk,org.kernel.vger.linux-devicetree |
|---|---|
| Message-ID | <[email protected]> |
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] Adding `power-domains` to the `qcom,sm8550-gcc` device tree node without updating the corresponding YAML binding causes a `dtbs_check` validation warning. -- --- Patch [12]: [PATCH 12/16] arm64: dts: qcom: sm8550: Add GCC CX power domain --- commit fbc80a89d2b6530024ab43fff461d5268dfeb3c4 Author: Abel Vesa <[email protected]> arm64: dts: qcom: sm8550: Add GCC CX power domain This commit adds a reference to the RPMh CX power domain for the GCC node on SM8550. This ensures that consumer votes propagate properly. > diff --git a/arch/arm64/boot/dts/qcom/sm8550.dtsi b/arch/arm64/boot/dts/qcom/sm8550.dtsi > index 0e701e709235c..7137efb453467 100644 > --- a/arch/arm64/boot/dts/qcom/sm8550.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm8550.dtsi > @@ -1195,6 +1195,7 @@ gcc: clock-controller@100000 { > <&ufs_mem_phy 1>, > <&ufs_mem_phy 2>, > <&usb_dp_qmpphy QMP_USB43DP_USB3_PIPE_CLK>; > + power-domains = <&rpmhpd RPMHPD_CX>; [Severity: Low] Does this change require a corresponding update to the device tree bindings YAML schema for qcom,sm8550-gcc? Adding the power-domains property here without documenting it in the binding schema will cause a dtbs_check validation warning. > }; -- Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=12