Re: [PATCH 10/16] arm64: dts: qcom: sm8350: Add GCC CX power domain
| Newsgroups | org.kernel.vger.linux-clk,org.kernel.vger.linux-devicetree |
|---|---|
| Message-ID | <[email protected]> |
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] The `power-domains` property is added to the SM8350 GCC device tree node, but it is not declared in the corresponding device tree binding schema (`qcom,gcc-sm8350.yaml`). -- --- Patch [10]: [PATCH 10/16] arm64: dts: qcom: sm8350: Add GCC CX power domain --- commit 114b5cd0dea1a6813cd14b2f585ff85d4973d4c9 Author: Abel Vesa <[email protected]> arm64: dts: qcom: sm8350: Add GCC CX power domain This commit adds the RPMh CX power domain as a reference in the SM8350 GCC node. This ensures that consumer votes for GCC-provided GDSCs properly propagate to the RPMh CX power domain. > diff --git a/arch/arm64/boot/dts/qcom/sm8350.dtsi b/arch/arm64/boot/dts/qcom/sm8350.dtsi > --- a/arch/arm64/boot/dts/qcom/sm8350.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm8350.dtsi > @@ -699,6 +699,7 @@ gcc: clock-controller@100000 { > <&ufs_mem_phy 2>, > <&usb_1_qmpphy QMP_USB43DP_USB3_PIPE_CLK>, > <0>; > + power-domains = <&rpmhpd RPMHPD_CX>; [Severity: Low] Does this property addition also need a corresponding update to the device tree binding schema in qcom,gcc-sm8350.yaml? Since power-domains is not currently declared in that schema, will this cause a validation error when running make dtbs_check? > }; -- Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=10