Re: [PATCH 09/16] arm64: dts: qcom: sm8250: Add GCC CX power domain
| Newsgroups | org.kernel.vger.linux-clk,org.kernel.vger.linux-devicetree |
|---|---|
| Message-ID | <[email protected]> |
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] Missing DT binding update for `power-domains` property. -- --- Patch [9]: [PATCH 09/16] arm64: dts: qcom: sm8250: Add GCC CX power domain --- commit 8ff2c27fe501198384b866811eea4d47f3a33812 Author: Abel Vesa <[email protected]> arm64: dts: qcom: sm8250: Add GCC CX power domain This commit adds a reference to the RPMh CX power domain for the GCC clock controller on SM8250. This ensures that GCC GDSC consumers correctly hold the required CX vote when enabling their local domain. > diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi > index 90f8b091634e9..50790cf1c3ca1 100644 > --- a/arch/arm64/boot/dts/qcom/sm8250.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi > @@ -971,6 +971,7 @@ gcc: clock-controller@100000 { > clocks = <&rpmhcc RPMH_CXO_CLK>, > <&rpmhcc RPMH_CXO_CLK_A>, > <&sleep_clk>; > + power-domains = <&rpmhpd RPMHPD_CX>; [Severity: Low] Does adding this property to the device tree without also updating the dt-binding schema for qcom,gcc-sm8250 cause a validation warning during make dtbs_check? If the schema restricts additional properties, the tools typically flag this new power-domains property as an unevaluated property. > }; -- Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=9