Re: [PATCH 13/16] arm64: dts: qcom: sm8650: Add GCC CX power domain

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The DT schema for SM8650 GCC does not define the 'power-domains' property, resulting in a dtbs_check validation failure.
--

--- Patch [13]: [PATCH 13/16] arm64: dts: qcom: sm8650: Add GCC CX power domain ---
commit 9a61032f8e0b737e1a6fc6895f1ca5a328c9b7d3
Author: Abel Vesa <[email protected]>

arm64: dts: qcom: sm8650: Add GCC CX power domain

This commit adds the RPMh CX power-domain reference to the SM8650 GCC
clock-controller node. This ensures consumers of GCC-provided GDSCs correctly
trigger the required CX vote when enabling their local domains.

> diff --git a/arch/arm64/boot/dts/qcom/sm8650.dtsi b/arch/arm64/boot/dts/qcom/sm8650.dtsi
> index b679fd8afb7d5..962797c15abf5 100644
> --- a/arch/arm64/boot/dts/qcom/sm8650.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8650.dtsi
> @@ -2019,6 +2019,8 @@ gcc: clock-controller@100000 {
[ ... ]
>  				 <&usb_dp_qmpphy QMP_USB43DP_USB3_PIPE_CLK>;
>  
> +			power-domains = <&rpmhpd RPMHPD_CX>;

[Severity: Low]
Does this new property require a corresponding update to the DT schema?

Looking at Documentation/devicetree/bindings/clock/qcom,sm8650-gcc.yaml,
it uses unevaluatedProperties: false but does not define the power-domains
property. Will adding this property to the device tree without updating the
bindings schema cause a validation failure during make dtbs_check?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=13