Re: [PATCH v2 03/12] block/blkio: fix compiler false-positive warning

Philippe Mathieu-Daudé <[email protected]> Mon, 27 Jul 2026 09:34:31 +0200
Newsgroups org.kernel.vger.linux-cxl,org.nongnu.qemu-devel
Message-ID <[email protected]>
On 26/7/26 22:44, Marc-André Lureau wrote:
> Under some optimization, gcc produces a false-positive:
>      ../block/blkio.c: In function ‘blkio_co_getlength’:
>      ../block/blkio.c:943:8: error: ‘ret’ may be used uninitialized [-Werror=maybe-uninitialized]
>        943 |     if (ret < 0) {
>            |        ^
> 
> Replace WITH_QEMU_LOCK_GUARD with the simpler QEMU_LOCK_GUARD.
> 
> Suggested-by: Akihiko Odaki <[email protected]>
> Signed-off-by: Marc-André Lureau <[email protected]>
> ---
>   block/blkio.c | 5 ++---
>   1 file changed, 2 insertions(+), 3 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <[email protected]>