Re: [PATCH v2 05/12] hw/cxl: fix invalid free on early return

On 27/7/26 06:40, Akihiko Odaki wrote:
> On 2026/07/27 6:09, Marc-André Lureau wrote:
>> On Mon, Jul 27, 2026 at 12:49 AM Michael S. Tsirkin <[email protected]> 
>> wrote:
>>>
>>> On Mon, Jul 27, 2026 at 12:44:04AM +0400, Marc-André Lureau wrote:
>>>> Fixes: 680935c9a6ff ("hw/cxl: Add a performant (and correct) path 
>>>> for the non interleaved cases")
>>>> Signed-off-by: Marc-André Lureau <[email protected]>
>>>
>>> Not commit log really?
>>
>> SSIA, but I can make it longer if it helps.
> 
> I agree the subject is sufficient so:
> 
> Reviewed-by: Akihiko Odaki <[email protected]>
> 
> That said, we can quote docs/devel/style.rst if desired:
> 
>  > * Variables declared with g_auto* MUST always be initialized,
>  >   otherwise the cleanup function will use uninitialized stack memory

Reviewed-by: Philippe Mathieu-Daudé <[email protected]>