[PATCH v7 5/8] cxl/hdm: Rename decoder coherency flags
Davidlohr Bueso <[email protected]> Tue, 28 Jul 2026 07:41:33 -0700
| Newsgroups | org.kernel.vger.linux-cxl |
|---|---|
| Message-ID | <[email protected]> |
Align with the ACPI CXL Window restriction naming and convert CXL_DECODER_F_TYPE2/F_TYPE3 to F_DEVMEM/F_HOSTONLY. Type2 and Type3 coherency models were named prior to Back-Invalidate. Reviewed-by: Ben Cheatham <[email protected]> Reviewed-by: Dave Jiang <[email protected]> Signed-off-by: Davidlohr Bueso <[email protected]> --- drivers/cxl/acpi.c | 8 ++++---- drivers/cxl/core/port.c | 12 ++++++------ drivers/cxl/cxl.h | 4 ++-- 3 files changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/cxl/acpi.c b/drivers/cxl/acpi.c index eceb8dd97df2..2c54f709c45d 100644 --- a/drivers/cxl/acpi.c +++ b/drivers/cxl/acpi.c @@ -143,9 +143,9 @@ static unsigned long cfmws_to_decoder_flags(int restrictions) unsigned long flags = CXL_DECODER_F_ENABLE; if (restrictions & ACPI_CEDT_CFMWS_RESTRICT_DEVMEM) - flags |= CXL_DECODER_F_TYPE2; + flags |= CXL_DECODER_F_DEVMEM; if (restrictions & ACPI_CEDT_CFMWS_RESTRICT_HOSTONLYMEM) - flags |= CXL_DECODER_F_TYPE3; + flags |= CXL_DECODER_F_HOSTONLY; if (restrictions & ACPI_CEDT_CFMWS_RESTRICT_VOLATILE) flags |= CXL_DECODER_F_RAM; if (restrictions & ACPI_CEDT_CFMWS_RESTRICT_PMEM) @@ -447,8 +447,8 @@ static int __cxl_parse_cfmws(struct acpi_cedt_cfmws *cfmws, cxld->flags = cfmws_to_decoder_flags(cfmws->restrictions); /* host-only wins if firmware sets both coherency restrictions */ cxld->target_type = CXL_DECODER_HOSTONLYMEM; - if (cxld->flags & CXL_DECODER_F_TYPE2) { - if (cxld->flags & CXL_DECODER_F_TYPE3) + if (cxld->flags & CXL_DECODER_F_DEVMEM) { + if (cxld->flags & CXL_DECODER_F_HOSTONLY) dev_dbg(dev, "CFMWS has both HDM-H and HDM-D\n"); else cxld->target_type = CXL_DECODER_DEVMEM; diff --git a/drivers/cxl/core/port.c b/drivers/cxl/core/port.c index 2dbd8c24f968..57882f4c2d8e 100644 --- a/drivers/cxl/core/port.c +++ b/drivers/cxl/core/port.c @@ -128,8 +128,8 @@ static DEVICE_ATTR_RO(name) CXL_DECODER_FLAG_ATTR(cap_pmem, CXL_DECODER_F_PMEM); CXL_DECODER_FLAG_ATTR(cap_ram, CXL_DECODER_F_RAM); -CXL_DECODER_FLAG_ATTR(cap_type2, CXL_DECODER_F_TYPE2); -CXL_DECODER_FLAG_ATTR(cap_type3, CXL_DECODER_F_TYPE3); +CXL_DECODER_FLAG_ATTR(cap_type2, CXL_DECODER_F_DEVMEM); +CXL_DECODER_FLAG_ATTR(cap_type3, CXL_DECODER_F_HOSTONLY); CXL_DECODER_FLAG_ATTR(locked, CXL_DECODER_F_LOCK); CXL_DECODER_FLAG_ATTR(cap_bi, CXL_DECODER_F_BI); @@ -364,8 +364,8 @@ static bool can_create_pmem(struct cxl_root_decoder *cxlrd) unsigned long flags = cxlrd->cxlsd.cxld.flags; unsigned long hdm_h, hdm_db; - hdm_h = CXL_DECODER_F_TYPE3 | CXL_DECODER_F_PMEM; - hdm_db = CXL_DECODER_F_TYPE2 | CXL_DECODER_F_BI | CXL_DECODER_F_PMEM; + hdm_h = CXL_DECODER_F_HOSTONLY | CXL_DECODER_F_PMEM; + hdm_db = CXL_DECODER_F_DEVMEM | CXL_DECODER_F_BI | CXL_DECODER_F_PMEM; return (flags & hdm_h) == hdm_h || (flags & hdm_db) == hdm_db; } @@ -375,8 +375,8 @@ static bool can_create_ram(struct cxl_root_decoder *cxlrd) unsigned long flags = cxlrd->cxlsd.cxld.flags; unsigned long hdm_h, hdm_db; - hdm_h = CXL_DECODER_F_TYPE3 | CXL_DECODER_F_RAM; - hdm_db = CXL_DECODER_F_TYPE2 | CXL_DECODER_F_BI | CXL_DECODER_F_RAM; + hdm_h = CXL_DECODER_F_HOSTONLY | CXL_DECODER_F_RAM; + hdm_db = CXL_DECODER_F_DEVMEM | CXL_DECODER_F_BI | CXL_DECODER_F_RAM; return (flags & hdm_h) == hdm_h || (flags & hdm_db) == hdm_db; } diff --git a/drivers/cxl/cxl.h b/drivers/cxl/cxl.h index ec2203561446..ca7051641c47 100644 --- a/drivers/cxl/cxl.h +++ b/drivers/cxl/cxl.h @@ -295,8 +295,8 @@ int cxl_dport_map_rcd_linkcap(struct pci_dev *pdev, struct cxl_dport *dport); */ #define CXL_DECODER_F_RAM BIT(0) #define CXL_DECODER_F_PMEM BIT(1) -#define CXL_DECODER_F_TYPE2 BIT(2) -#define CXL_DECODER_F_TYPE3 BIT(3) +#define CXL_DECODER_F_DEVMEM BIT(2) +#define CXL_DECODER_F_HOSTONLY BIT(3) #define CXL_DECODER_F_LOCK BIT(4) #define CXL_DECODER_F_ENABLE BIT(5) #define CXL_DECODER_F_NORMALIZED_ADDRESSING BIT(6) -- 2.39.5