Re: [PATCH 06/28] arm64: dts: qcom: sm8150: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:

Pre-existing issues:
- [High] Incomplete fix: Swapped QMP PHY voltage supplies remain in sa8155p-adp.dts
--

--- Patch [6]: [PATCH 06/28] arm64: dts: qcom: sm8150: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies ---
commit ebfb4d71483e3fc04d67c48f9f15befd5ec2bbed
Author: Manivannan Sadhasivam <[email protected]>

arm64: dts: qcom: sm8150: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies

This commit fixes an issue where the 1.2V and 0.88V supplies were swapped
for the USB QMP PHYs on several SM8150 boards. It restores the correct
voltages by feeding 0.88V to vdda-phy and 1.2V to vdda-pll.

> The QMP PHY expects the vdda-phy supply to be around 0.88V and the
> vdda-pll supply to be 1.2V. But these two supplies are swapped for the
> USB QMP PHYs on these boards, feeding 1.2V to vdda-phy and 0.88V to
> vdda-pll.
>
> Fix it by swapping the two supplies back.

[Severity: High]
This is a pre-existing issue, but since this patch fixes swapped QMP PHY 
supplies across SM8150 boards, does it miss the SA8155P automotive variant?

Looking at the existing arch/arm64/boot/dts/qcom/sa8155p-adp.dts, ufs_mem_phy 
and usb_2_qmpphy still retain the swapped supplies:

arch/arm64/boot/dts/qcom/sa8155p-adp.dts:ufs_mem_phy {
        ...
        vdda-phy-supply = <&vreg_l8c_1p2>;
        vdda-pll-supply = <&vreg_l5a_0p88>;
};

arch/arm64/boot/dts/qcom/sa8155p-adp.dts:usb_2_qmpphy {
        ...
        vdda-phy-supply = <&vreg_l8c_1p2>;
        vdda-pll-supply = <&vdda_usb_ss_dp_core_1>;
};

(Where vdda_usb_ss_dp_core_1 is an alias for the 0.88V regulator 
vreg_l5a_0p88).

Should these nodes in sa8155p-adp.dts also be updated to prevent overvoltage 
degradation on this board?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=6