Re: [PATCH 12/28] arm64: dts: qcom: qcm6490: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:

Pre-existing issues:
- [High] The patch series corrects the swapped `vdda-phy` and `vdda-pll` supplies for several QCM6490 boards, but misses numerous other QCS6490, SC7280, and SC7180 boards that suffer from the exact same misconfiguration.
--

--- Patch [12]: [PATCH 12/28] arm64: dts: qcom: qcm6490: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies ---
commit 25fe3724f708ab3e601c6a304dd1dd8d5ed9eef1
Author: Manivannan Sadhasivam <[email protected]>

arm64: dts: qcom: qcm6490: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies

This patch fixes the swapped vdda-phy and vdda-pll supplies for the USB QMP
PHYs on several QCM6490 boards. The QMP PHY expects 0.88V for vdda-phy and
1.2V for vdda-pll, but the device trees previously supplied 1.2V to vdda-phy
and 0.9V to vdda-pll.

> diff --git a/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts b/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts
> index 04cb9230d29fd..92a7d80b7fee6 100644
> --- a/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts
> +++ b/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts
> @@ -1502,8 +1502,8 @@ &usb_1_hsphy {
>  };
>  
>  &usb_1_qmpphy {
> -	vdda-phy-supply = <&vreg_l6b>;
> -	vdda-pll-supply = <&vreg_l1b>;
> +	vdda-phy-supply = <&vreg_l1b>;
> +	vdda-pll-supply = <&vreg_l6b>;

[Severity: High]
This is a pre-existing issue, but while you are fixing these QCM6490 boards,
it looks like several other boards in the tree suffer from the exact same
swapped regulator configuration.

Should these boards be fixed as well to avoid over-volting the phy domains?

For example, in arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts:

&usb_1_qmpphy {
	vdda-phy-supply = <&vreg_l6b_1p2>;
	vdda-pll-supply = <&vreg_l1b_0p912>;

And similarly in SC7280 and SC7180 boards, such as
arch/arm64/boot/dts/qcom/sc7180-idp.dts:

&usb_1_qmpphy {
	vdda-phy-supply = <&vreg_l3c_1p2>;
	vdda-pll-supply = <&vreg_l4a_0p8>;

Other unpatched boards with the same misconfiguration in usb_1_qmpphy include:
- arch/arm64/boot/dts/qcom/qcs6490-thundercomm-minipc-g1iot.dts
- arch/arm64/boot/dts/qcom/qcs6490-thundercomm-rubikpi3.dts
- arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
- arch/arm64/boot/dts/qcom/sc7180-acer-aspire1.dts
- arch/arm64/boot/dts/qcom/sc7180-ecs-liva-qc710.dts

>  
>  	status = "okay";
>  };

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=12