Re: [PATCH 02/28] arm64: dts: qcom: sc8280xp-blackrock: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:

Pre-existing issues:
- [High] The DP and PCIe QMP PHYs in the blackrock device tree suffer from the same swapped voltage supply bug that the commit fixes for the USB PHYs.
--

--- Patch [2]: [PATCH 02/28] arm64: dts: qcom: sc8280xp-blackrock: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies ---
commit 2ff4552e01c34fa2dc6f9a24da3173abd76e8b38
Author: Manivannan Sadhasivam <[email protected]>

arm64: dts: qcom: sc8280xp-blackrock: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies

The QMP PHY expects the vdda-phy supply to be around 0.88V and the
vdda-pll supply to be 1.2V. But these two supplies are swapped for the
USB QMP PHYs on this board, feeding 1.2V to vdda-phy and 0.9V to
vdda-pll. This commit fixes the issue by swapping the two supplies back.

> diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-microsoft-blackrock.dts b/arch/arm64/boot/dts/qcom/sc8280xp-microsoft-blackrock.dts
> index 125af356e24b9..4e74eda7405f3 100644
> --- a/arch/arm64/boot/dts/qcom/sc8280xp-microsoft-blackrock.dts
> +++ b/arch/arm64/boot/dts/qcom/sc8280xp-microsoft-blackrock.dts
[ ... ]
> @@ -1040,8 +1040,8 @@ &usb_1_hsphy {
>  };
>  
>  &usb_1_qmpphy {
> -	vdda-phy-supply = <&vreg_l3b>;
> -	vdda-pll-supply = <&vreg_l4b>;
> +	vdda-phy-supply = <&vreg_l4b>;
> +	vdda-pll-supply = <&vreg_l3b>;
>  
>  	orientation-switch;
>  

[Severity: High]
This is a pre-existing issue, but it looks like the DP and PCIe QMP PHYs in
this file suffer from the same swapped voltage supply bug.

For example, in the mdss0_dp2_phy node, vreg_l3b (1.2V) is used for vdda-phy
and vreg_l6b (0.88V) is used for vdda-pll:

	vdda-phy-supply = <&vreg_l3b>;
	vdda-pll-supply = <&vreg_l6b>;

Similarly, the pcie2a_phy and pcie4_phy nodes both incorrectly use vreg_l4d
(1.2V) for vdda-phy and vreg_l6d (0.88V) for vdda-pll:

	vdda-phy-supply = <&vreg_l4d>;
	vdda-pll-supply = <&vreg_l6d>;

Operating these PHYs with the swapped voltages might cause hardware
instability or functional failures. Should these nodes also be updated to
fix the swapped supplies?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=2