Re: [PATCH 05/28] arm64: dts: qcom: sdm850: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:

Pre-existing issues:
- [High] Incomplete fix: QMP USB PHY vdda-phy and vdda-pll supplies remain swapped on SC7180 and SC7280 boards.
--

--- Patch [5]: [PATCH 05/28] arm64: dts: qcom: sdm850: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies ---
commit 65f1a14faee30f3ce9d68212652a11c2bcb4b004
Author: Manivannan Sadhasivam <[email protected]>

arm64: dts: qcom: sdm850: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies

This commit resolves swapped vdda-phy and vdda-pll supplies for USB QMP PHYs
on several sdm850 boards. It ensures the vdda-phy receives the expected 0.88V
instead of 1.2V, and the vdda-pll receives 1.2V instead of 0.88V.

> The QMP PHY expects the vdda-phy supply to be around 0.88V and the
> vdda-pll supply to be 1.2V. But these two supplies are swapped for the
> USB QMP PHYs on these boards, feeding 1.2V to vdda-phy and 0.88V to
> vdda-pll.
> 
> Fix it by swapping the two supplies back.

[Severity: High]
This isn't a bug introduced by this patch, but it appears the identical
configuration remains swapped on other boards, such as SC7180 and SC7280.
For example, in arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi:

    vdda-phy-supply = <&vdda_usb_ss_dp_1p2>;
    vdda-pll-supply = <&vdda_usb_ss_dp_core>;

And similarly in arch/arm64/boot/dts/qcom/sc7280-idp.dtsi:

    vdda-phy-supply = <&vreg_l6b_1p2>;
    vdda-pll-supply = <&vreg_l1b_0p8>;

Since vdda-phy receives 1.2V and vdda-pll receives 0.88V/0.9V on these pins,
could this cause hardware damage over time or prevent the USB PHY from locking
on these systems as well? Should these other boards be included in this fix?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=5