Re: [PATCH 18/28] arm64: dts: qcom: hamoa: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:

Pre-existing issues:
- [High] Incomplete fix: Snapdragon X Plus (purwa/x1p) boards were missed and continue to supply incorrect voltages to the USB QMP PHYs.
--

--- Patch [18]: [PATCH 18/28] arm64: dts: qcom: hamoa: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies ---
commit 56ae73fe6fa593d516dd7a86b9b535d8c22c1819
Author: Manivannan Sadhasivam <[email protected]>

arm64: dts: qcom: hamoa: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies

This commit fixes an issue across multiple Snapdragon boards where the 1.2V
and 0.88V regulators for the USB QMP PHY were incorrectly swapped. The patch
swaps vdda-phy-supply and vdda-pll-supply back to their correct voltages for
the affected devices.

> diff --git a/arch/arm64/boot/dts/qcom/hamoa-iot-som.dtsi b/arch/arm64/boot/dts/qcom/hamoa-iot-som.dtsi
> index 9c5e77df00547..bc70fe5db96f5 100644
> --- a/arch/arm64/boot/dts/qcom/hamoa-iot-som.dtsi
> +++ b/arch/arm64/boot/dts/qcom/hamoa-iot-som.dtsi
> @@ -590,8 +590,8 @@ &usb_1_ss0_hsphy {
>  };
>  
>  &usb_1_ss0_qmpphy {
> -	vdda-phy-supply = <&vreg_l2j_1p2>;
> -	vdda-pll-supply = <&vreg_l1j_0p8>;
> +	vdda-phy-supply = <&vreg_l1j_0p8>;
> +	vdda-pll-supply = <&vreg_l2j_1p2>;
>  
>  	status = "okay";
>  };

[Severity: High]
This is a pre-existing issue, but it looks like some Snapdragon X Plus (purwa/x1p)
boards were missed and continue to supply incorrect voltages to the USB QMP PHYs.

For example, in arch/arm64/boot/dts/qcom/purwa-iot-som.dtsi around line 586
for usb_1_ss0_qmpphy:

&usb_1_ss0_qmpphy {
	vdda-phy-supply = <&vreg_l2j_1p2>;
	vdda-pll-supply = <&vreg_l1j_0p8>;

And similarly in arch/arm64/boot/dts/qcom/x1p42100-lenovo-thinkbook-16.dts
around line 1590 for usb_1_ss0_qmpphy:

&usb_1_ss0_qmpphy {
	vdda-phy-supply = <&vreg_l2j_1p2>;
	vdda-pll-supply = <&vreg_l1j_0p8>;

Should these files be updated as well to prevent unconditionally feeding 1.2V
into the 0.88V PHY rails on those boards during boot?

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=18