Re: [PATCH 13/28] arm64: dts: qcom: qcs6490: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:

Pre-existing issues:
- [High] The patch series fixes swapped `vdda-phy` and `vdda-pll` supplies for the QMP USB PHY on various boards, but misses identical misconfigurations on other closely related boards such as SC7280, SC7180, and SM7225.
--

--- Patch [13]: [PATCH 13/28] arm64: dts: qcom: qcs6490: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies ---
commit 0c6d97f5f784273baeb5afe41418c7609191becd
Author: Manivannan Sadhasivam <[email protected]>

arm64: dts: qcom: qcs6490: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies

This patch corrects the swapped vdda-phy and vdda-pll supplies for the USB QMP
PHY on QCS6490 boards.

> diff --git a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
> index 37a3b51323ce5..8e200ba3711ae 100644
> --- a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
> +++ b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
> @@ -1419,8 +1419,8 @@ &usb_1_hsphy {
>  };
>  
>  &usb_1_qmpphy {
> -	vdda-phy-supply = <&vreg_l6b_1p2>;
> -	vdda-pll-supply = <&vreg_l1b_0p912>;
> +	vdda-phy-supply = <&vreg_l1b_0p912>;
> +	vdda-pll-supply = <&vreg_l6b_1p2>;

[Severity: High]
This isn't a bug introduced by this patch, but since you are fixing the
swapped supplies here, should this fix also be applied to other closely
related boards that appear to have the exact same misconfiguration?

For example, in arch/arm64/boot/dts/qcom/sc7280-idp.dtsi:

&usb_1_qmpphy {
	vdda-phy-supply = <&vreg_l6b_1p2>;
	vdda-pll-supply = <&vreg_l1b_0p8>;
}

And in arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi:

&usb_1_qmpphy {
	vdda-phy-supply = <&vdd_a_usbssdp_0_1p2>;
	vdda-pll-supply = <&vdd_a_usbssdp_0_core>;
}

Similarly in arch/arm64/boot/dts/qcom/sc7180-ecs-liva-qc710.dts:

&usb_1_qmpphy {
	vdda-phy-supply = <&vreg_l3c_1p2>;
	vdda-pll-supply = <&vreg_l4a_0p8>;
}

>  
>  	orientation-switch;

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=13