Re: [PATCH 03/28] arm64: dts: qcom: sa8540p: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:

Pre-existing issues:
- [High] Swapped PHY and PLL regulator supplies in additional Qualcomm boards missed by patch series.
--

--- Patch [3]: [PATCH 03/28] arm64: dts: qcom: sa8540p: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies ---
commit f7f68ce606103ed03353b8e43b7fb5b5dfb4a92b
Author: Manivannan Sadhasivam <[email protected]>

arm64: dts: qcom: sa8540p: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies

The QMP PHY expects the vdda-phy supply to be around 0.88V and the vdda-pll
supply to be 1.2V. This patch fixes an issue where these two supplies were
swapped for the USB QMP PHYs on SA8540P and SA8295P boards.

> diff --git a/arch/arm64/boot/dts/qcom/sa8295p-adp.dts b/arch/arm64/boot/dts/qcom/sa8295p-adp.dts
> index d28d691624279..7178ae087038c 100644
> --- a/arch/arm64/boot/dts/qcom/sa8295p-adp.dts
> +++ b/arch/arm64/boot/dts/qcom/sa8295p-adp.dts
> @@ -604,8 +604,8 @@ &usb_0_hsphy {
>  };
>  
>  &usb_0_qmpphy {
> -	vdda-phy-supply = <&vreg_l3a>;
> -	vdda-pll-supply = <&vreg_l5a>;
> +	vdda-phy-supply = <&vreg_l5a>;
> +	vdda-pll-supply = <&vreg_l3a>;

[Severity: High]
This isn't a bug introduced by this patch, but while reviewing this fix I
noticed that identical swapped PHY and PLL supplies seem to exist in other
Qualcomm boards missed by this patch series.

For instance, in arch/arm64/boot/dts/qcom/sc8280xp-microsoft-blackrock.dts
for pcie2a_phy and pcie4_phy:

&pcie2a_phy {
	vdda-phy-supply = <&vreg_l4d>;
	vdda-pll-supply = <&vreg_l6d>;

Here 1.2V (vreg_l4d) is fed to the 0.88V vdda-phy rail and 0.88V (vreg_l6d) is
fed to the 1.2V vdda-pll rail.

Similarly, in arch/arm64/boot/dts/qcom/lemans-evk.dts (usb_0_qmpphy) and
arch/arm64/boot/dts/qcom/lemans-ride-common.dtsi (usb_0_qmpphy and
usb_1_qmpphy):

&usb_0_qmpphy {
	vdda-phy-supply = <&vreg_l1c>;
	vdda-pll-supply = <&vreg_l7a>;

This also mistakenly feeds 1.2V to the 0.88V rail and 0.88V to the 1.2V rail
during device probe at boot.

Are these additional nodes also causing a deterministic overvoltage on the PHY
circuitry that risks hardware damage, and should they be fixed as well?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=3