Re: [PATCH v9 29/36] pinctrl: airoha: an7583: add support for pon_alt pinmux

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The 'pon_alt' pin group is supported by the driver but missing from the device tree binding schema.
--

--- Patch [29]: [PATCH v9 29/36] pinctrl: airoha: an7583: add support for pon_alt pinmux ---
commit 3bd160b8a39fbe75c5055ffadbed0b4b260b0922
Author: Mikhail Kshevetskiy <[email protected]>

pinctrl: airoha: an7583: add support for pon_alt pinmux

This commit adds support for the pon pin function for the pon_alt pin group.

> diff --git a/drivers/pinctrl/airoha/pinctrl-an7583.c b/drivers/pinctrl/airoha/pinctrl-an7583.c
> index dc88cbd8746bb..2e145ef5a224c 100644
> --- a/drivers/pinctrl/airoha/pinctrl-an7583.c
> +++ b/drivers/pinctrl/airoha/pinctrl-an7583.c
[ ... ]
> @@ -564,7 +567,7 @@ static const struct pingroup pinctrl_groups[] = {
>  	PINCTRL_PIN_GROUP("pcie_reset1", pcie_reset1),
>  };
>  
> -static const char *const pon_groups[] = { "pon" };
> +static const char *const pon_groups[] = { "pon", "pon_alt" };

[Severity: Low]
Since "pon_alt" is now supported by the driver for the "pon" function, does
the device tree binding schema also need an update?

Looking at Documentation/devicetree/bindings/pinctrl/airoha,an7583-pinctrl.yaml,
the schema restricts the allowed pin groups for the "pon" function:

        allOf:
          - if:
              properties:
                function:
                  const: pon
            then:
              properties:
                groups:
                  enum: [pon]

Will this cause dtbs_check to fail when a device tree uses the new "pon_alt"
configuration?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=29