Re: [PATCH v10 29/36] pinctrl: airoha: an7583: add support for pon_alt pinmux

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Missing devicetree binding update for the new `pon_alt` pin group
--

--- Patch [29]: [PATCH v10 29/36] pinctrl: airoha: an7583: add support for pon_alt pinmux ---
commit e4aace775344077581e730c5d2b97d324007c209
Author: Mikhail Kshevetskiy <[email protected]>

pinctrl: airoha: an7583: add support for pon_alt pinmux

This commit adds the pon_alt pin group and enables the pon pin function
for it.

> diff --git a/drivers/pinctrl/airoha/pinctrl-an7583.c b/drivers/pinctrl/airoha/pinctrl-an7583.c
> index dc88cbd8746bb..2e145ef5a224c 100644
> --- a/drivers/pinctrl/airoha/pinctrl-an7583.c
> +++ b/drivers/pinctrl/airoha/pinctrl-an7583.c

[ ... ]

> @@ -564,7 +567,7 @@ static const struct pingroup pinctrl_groups[] = {
>  	PINCTRL_PIN_GROUP("pcie_reset1", pcie_reset1),
>  };
>  
> -static const char *const pon_groups[] = { "pon" };
> +static const char *const pon_groups[] = { "pon", "pon_alt" };

[Severity: Low]
Is a corresponding update to the devicetree binding schema needed alongside
this change?

Looking at the bindings in
Documentation/devicetree/bindings/pinctrl/airoha,an7583-pinctrl.yaml, the
schema strictly restricts the allowed groups for the pon function:

          - if:
              properties:
                function:
                  const: pon
            then:
              properties:
                groups:
                  enum: [pon]

Without updating the schema, will dtbs_check fail with validation errors when
developers attempt to use the newly added pon_alt group in their devicetrees?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=29