Re: [PATCH v10 28/36] pinctrl: airoha: an7583: add support for npu_uart pinmux

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The patch adds a new `npu_uart` pin group to the `uart` function in the pinctrl driver but fails to update the corresponding devicetree bindings (`airoha,an7583-pinctrl.yaml`), which will cause `dtbs_check` validation to fail for device trees using this pin group.
--

--- Patch [28]: [PATCH v10 28/36] pinctrl: airoha: an7583: add support for npu_uart pinmux ---
commit 7fc23e1570287d709b03bd9508c42c7bac7231dd
Author: Mikhail Kshevetskiy <[email protected]>

pinctrl: airoha: an7583: add support for npu_uart pinmux

This commit adds support for the uart pin function for the npu_uart pin group.

> diff --git a/drivers/pinctrl/airoha/pinctrl-an7583.c b/drivers/pinctrl/airoha/pinctrl-an7583.c
> index 44efccce78c55..dc88cbd8746bb 100644
> --- a/drivers/pinctrl/airoha/pinctrl-an7583.c
> +++ b/drivers/pinctrl/airoha/pinctrl-an7583.c
[ ... ]
> @@ -571,7 +572,7 @@ static const char *const sipo_groups[] = { "sipo", "sipo_rclk" };
>  static const char *const mdio_groups[] = { "mdio" };
>  static const char *const uart_groups[] = {
>  	"uart2", "uart2_cts_rts", "hsuart", "hsuart_cts_rts",
> -	"uart4", "uart5"
> +	"uart4", "uart5", "npu_uart"
>  };

[Severity: Low]
Does this change also require an update to the device tree bindings?

The npu_uart group is added to the uart function here, but it appears to be
missing from the allowed enum items in
Documentation/devicetree/bindings/pinctrl/airoha,an7583-pinctrl.yaml:

          - if:
              properties:
                function:
                  const: uart
            then:
              properties:
                groups:
                  items:
                    enum: [uart2, uart2_cts_rts, hsuart, hsuart_cts_rts,
                           uart4, uart5]

Without adding npu_uart to this list, will dtbs_check validation fail for
device trees that attempt to use the newly added group?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=28