Re: [PATCH v10 36/36] dt-bindings: pinctrl: airoha: add support of an7563 pin controller

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The device tree example uses a deprecated integer syntax for the `drive-open-drain` property.
--

--- Patch [36]: [PATCH v10 36/36] dt-bindings: pinctrl: airoha: add support of an7563 pin controller ---
commit 083c48588a39707f2654e880799e2efa014bed0b
Author: Mikhail Kshevetskiy <[email protected]>

dt-bindings: pinctrl: airoha: add support of an7563 pin controller

This patch adds the device tree binding schema for the Airoha AN7563 SoC
pin controller. It defines pin multiplexing and configuration properties,
including an example node configuration.

> diff --git a/Documentation/devicetree/bindings/pinctrl/airoha,an7563-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/airoha,an7563-pinctrl.yaml
> new file mode 100644
> index 0000000000000..e626d34661285
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/pinctrl/airoha,an7563-pinctrl.yaml

[ ... ]

> +examples:
> +  - |
> +    #include <dt-bindings/interrupt-controller/arm-gic.h>
> +
> +    pinctrl {
> +      compatible = "airoha,an7563-pinctrl";
> +
> +      interrupt-parent = <&gic>;
> +      interrupts = <GIC_SPI 26 IRQ_TYPE_LEVEL_HIGH>;
> +
> +      gpio-controller;
> +      #gpio-cells = <2>;
> +
> +      interrupt-controller;
> +      #interrupt-cells = <2>;
> +
> +      pcie1-rst-pins {
> +        conf {
> +          pins = "pcie_reset1";
> +          drive-open-drain = <1>;

[Severity: Low]
Does this example use a deprecated integer syntax for the drive-open-drain
property?

The schema defines drive-open-drain as a boolean flag. Using the integer
syntax <1> will trigger dt-validate warnings. Would it be better to write
this as just "drive-open-drain;"?

> +        };
> +      };

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=36